-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Distance – show "Add stop" button only when start & finish are filled #31017
fix: Distance – show "Add stop" button only when start & finish are filled #31017
Conversation
@cubuspl42 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
src/pages/iou/WaypointEditor.js
Outdated
@@ -148,7 +138,7 @@ function WaypointEditor({route: {params: {iouType = '', transactionID = '', wayp | |||
lng: null, | |||
address: waypointValue, | |||
}; | |||
saveWaypoint(waypoint); | |||
Transaction.saveWaypoint(transactionID, waypointIndex, waypoint); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@paultsimura What do you think about adding isEditingWaypoint param here?
@paultsimura User still can add stop by accessing deeplink. So I think we need to update condition here App/src/pages/iou/WaypointEditor.js Line 187 in c2e4042
using (parsedWaypointIndex > 1 && parsedWaypointIndex > numberOfFilledWaypoints) instead of using waypointCount
|
Thank you, that's a reasonable catch. Considering that we do not share these links anywhere, the only case when a user can access this page is by manually changing the URL to |
@DylanDylann Thanks for catching this! @paultsimura Yes, we should handle it. The URL bar is an extension of the app's UI. It's not like the user typed something to the developer console, after all. |
Cool, I'm on it |
I have added a new condition: |
Minor refactoring.
11628a5
to
d4fe698
Compare
@cubuspl42 all yours☝🏼 |
Please make it clear that it should appear after both mentioned fields are filled Please add a step that ensures that the button disappears while again < 2 waypoints are filled (use user's terms) |
Reviewer Checklist
Screenshots/VideosWebdistance-stop-button-web.mp4Mobile Web - Chromedistance-stop-button-android-web-compressed.mp4Mobile Web - Safaridistance-stop-button-ios-web.mp4DesktopiOSdistance-stop-button-ios.mp4Androiddistance-stop-button-android-compressed.mp4 |
@cubuspl42, updated the PR description and renamed vars. |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/iwiznia in version: 1.3.99-0 🚀
|
🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.99-0 🚀
|
🚀 Deployed to staging by https://github.com/iwiznia in version: 1.4.0-0 🚀
|
Details
Show the "Add stop" button for Distance requests only when start & finish are filled.
Fixed Issues
$ #29886
PROPOSAL: #29886 (comment)
Tests
Same as QA.
Offline tests
Same as QA.
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android-compressed.mp4
Android: mWeb Chrome
chrome.mp4
iOS: Native
iOS.mp4
iOS: mWeb Safari
safari.mp4
MacOS: Chrome / Safari
web.mp4
MacOS: Desktop
Desktop.mp4